Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove unused httpx package #1579

Merged
merged 1 commit into from
Apr 30, 2024
Merged

cleanup: remove unused httpx package #1579

merged 1 commit into from
Apr 30, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone requested a review from hellais as a code owner April 30, 2024 15:52
bassosimone
bassosimone commented Apr 30, 2024
View reviewed changes
internal/httpx/httpx.go

// DefaultMaxBodySize is the default value for the maximum
// body size you can fetch using an APIClient.
const DefaultMaxBodySize = 1 << 22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

httpapi and httpclientx use 1<<24.

@bassosimone bassosimone merged commit a628af2 into master Apr 30, 2024
17 of 19 checks passed
@bassosimone bassosimone deleted the issue/2723d branch April 30, 2024 16:08
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone