Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deleting all measurements #158

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Add support for deleting all measurements #158

merged 4 commits into from
Nov 13, 2020

Conversation

hellais
Copy link
Member

@hellais hellais commented Nov 9, 2020

Implements: ooni/probe#1276

This is currently blocking from building due to:

../../../golang/pkg/mod/github.com/ooni/probe-engine@v0.19.0/readme_compiletimecheck.go:6:1: syntax error: non-declaration statement outside function body
upper.io/db.v3/sqlite

@hellais hellais mentioned this pull request Nov 10, 2020
Open
bassosimone
bassosimone reviewed Nov 13, 2020
View reviewed changes
internal/cli/rm/rm.go Outdated Show resolved Hide resolved
bassosimone
bassosimone reviewed Nov 13, 2020
View reviewed changes
internal/cli/rm/rm.go Outdated Show resolved Hide resolved
bassosimone
bassosimone reviewed Nov 13, 2020
View reviewed changes
internal/cli/rm/rm.go Outdated Show resolved Hide resolved
@bassosimone bassosimone mentioned this pull request Nov 13, 2020
Closed
@bassosimone
Copy link
Contributor

Thanks @hellais for implementing this feature! <3

@bassosimone bassosimone merged commit c0a95c0 into master Nov 13, 2020
@bassosimone bassosimone deleted the delete-all-measurements branch November 13, 2020 06:43
ainghazal pushed a commit to ainghazal/probe-cli that referenced this pull request Mar 8, 2022
@hellais @bassosimone
Add support for deleting all measurements (ooni#158)
a070c0a 
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellais @bassosimone