-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fallback domain names for openvpn experiment #1654
feat: add fallback domain names for openvpn experiment #1654
Conversation
while working on this, I also gave more priority to possible oonirun descriptors passed in the command line. - Related: #2805
changed the logic after 1:1 with @hellais, ready for review |
e5411af
to
78ac661
Compare
To clarify, I've added a few more comments to the docstring of the Load() function. An error is ignored (logged now); returning the empty list (in case of all bogons) is equivalent of passing an empty input list to the experiment. @hellais: here I've pointed both domains to localhost in /etc/hosts, see:
To trace the execution path, and reason about it, I think the right place to go is the the call to In turn, inputprocessor.Run calls inputprocessor.run, which loops over the array of inputs. I think this ensures that an empty array runs the experiment zero times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I pushed a change to the go.sum
file here: ffbd670, to update the minivpn
dependency to v0.0.7
.
while working on this, I also gave more priority to possible oonirun descriptors passed in the command line.
Checklist
Description
Add fallback domains for openvpn default endpoints to be probed.