Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oonimkall): expose the session close call #1657

Merged
merged 2 commits into from
Nov 21, 2024
Merged

refactor(oonimkall): expose the session close call #1657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
412c35b
refactor(oonimkall): expose the session close call
DecFox Oct 25, 2024
5ccf818
improve Session close comment
DecFox Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/oonimkall/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,13 @@ func (sess *Session) NewContextWithTimeout(timeout int64) *Context {
return &Context{cancel: cancel, ctx: ctx}
}

// Close closes the session. This is done by closing the embedded engine
// session and ensures that any tunnel (if open) is stopped
func (sess *Session) Close() error {
err := sess.sessp.Close()
return err
}

// GeolocateResults contains the results of session.Geolocate.
type GeolocateResults struct {
// ASN is the autonomous system number.
Expand Down
Loading