enable utls for websteps #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
suggested changes
Aug 18, 2021
go.mod
Outdated
| @@ -28,6 +28,7 @@ require ( | |||
| github.com/miekg/dns v1.1.42 | |||
| github.com/mitchellh/go-wordwrap v1.0.1 | |||
| github.com/montanaflynn/stats v0.6.6 | |||
| github.com/ooni/oohttp v0.0.0-20210817213129-35949dcf526f // indirect | |||
There was a problem hiding this comment.
Why is this indirect? Do you mind running go mod tidy and see whether it fixes this line?
|
|
||
| transport = &netxlite.HTTPTransportLogger{Logger: log.Log, HTTPTransport: transport.(*http.Transport)} | ||
| // NewBaseTransport creates a new HTTP transport with the default dialer. | ||
| func NewBaseTransport() (transport *oohttp.StdlibTransport) { |
There was a problem hiding this comment.
Can you make this function private?
bassosimone
reviewed
Aug 18, 2021
| @@ -1,96 +0,0 @@ | |||
| package websteps | |||
There was a problem hiding this comment.
For the records: this file has been deleted because a similar functionality was in the websteps experiment
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
This diff enables `websteps` to use uTLS for TLS parroting. It integrates the `oohttp.StdlibTransport` wrapper which uses the `ooni/oohttp` fork. `oohttp` supports TLS-like connections like `utls.Conn`. As a prototype, the testhelper and `websteps` code now uses the `utls.HelloChrome_Auto` fingerprint, i.e. the simulated TLS fingerprint of the Google Chrome browser. It is a further contribution for my GSoC project. Reference issue: ooni/probe#1733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff enables
webstepsto use uTLS for TLS parroting. It integrates theoohttp.StdlibTransportwrapper which uses theooni/oohttpfork.oohttpsupports TLS-like connections likeutls.Conn.As a prototype, the testhelper and
webstepscode now uses theutls.HelloChrome_Autofingerprint, i.e. the simulated TLS fingerprint of the Google Chrome browser.It is a further contribution for my GSoC project.
Reference issue: ooni/probe#1733