-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to lucas-clemente/quic-go v0.23.0 #448
Conversation
// This code introduces the UDPLikeConn, whose documentation explain | ||
// why we need to introduce this new type. We could not put this | ||
// code inside an existing package because it's used (as of 20 Aug 2021) | ||
// by the netxlite package as well as by the netx package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// by the netxlite package as well as by the netx package. | |
// by the netxlite package as well as by the netxmocks package. |
When running
It's important to note that we don't see any From the above data we can deduce that:
I am going to open an issue for the former problem and to fix the latter as part of this pull request. |
Even after d587f5a, we are still without the |
Superseded by ooni/probe#1754, for which a PR will come soon. |
Checklist
Location of the issue tracker: https://github.com/ooni/probe
Description
This pull request updates to lucas-clemente/quic-go v0.23.0. Updating leads to several CI runtime errors (see, e.g., this failed run: #441 (comment)). To avoid these errors, when we are listening for QUIC, we need to return a type that is both a
quic.OOBCapablePacketConn
andnet.Conn
. Otherwise, the underlyinggolang.org/x/net/ipv4.NewPacketConn
function is going to panic because we are using a connection that cannot be converted to anet.Conn
. Therefore, this PR introduces a newinternal/quicx.UDPLikeConn
interface that implements bothquic.OOBCapablePacketConn
andnet.Conn
. See ooni/probe#1739.It is also worth mentioning that this problem arose in #441, which contained backports from the
stable
branch. Since authoring these changes, I realised it's quite pointless to apply more changes in the stable branch, so I dropped f0d05c5 from the patchset.