feat(bwmon): monitor bandwidth usage #531
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is experimental code that was part of the branch #506 and that I am not sure whether it could really be useful when running in prod, but may be useful for running some benchmarks of websteps vs webconnectivity.
3 tasks
This is the most immediate fix to the issue described by ooni/probe#1792. So, the logic was actually miss the increment, which would have been noticed with proper unit testing. Anyway, I am not sure why the loop ensues in the first time. By looking at the headers, it seems we're passing the headers correctly. So, even though this fix interrupts the loop, it still remains the question of whether the loop is legit or whether we're missing extra logic to properly redirect.
Seems useful for ooni/probe#1797
After calibration I can confirm we can provoke losses on both paths and we can increase delay on both paths. Likewise, I can apply a TBF w/o netem.
After calibration I can confirm we can provoke losses on both paths and we can increase delay on both paths. Likewise, I can apply a TBF w/o netem.
This diff should help us to more easily do A/B testing with parroting. Unclear whether we want to have this merged into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
REFERENCE_ISSUE_URLRELATED_OONI_SPEC_PULL_REQUEST_URLLocation of the issue tracker: https://github.com/ooni/probe
Description
This is experimental code that was part of the branch
#506 and that
I am not sure whether it could really be useful when
running in prod, but may be useful for running some
benchmarks of websteps vs webconnectivity.