fix: build ooniprobe for linux using debian/amd64 #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ooni/probe#1741, we observed that every attempt to use `docker --platform` along with `debian` for packaging ooniprobe fails with `SEGFAULT`, except when using the `debian:oldstable` container. To fix this issue, in this diff we fix Debian packaging to run on any debian system (`debian:stable` in our case) provided that we have `qemu-user-static` installed on the system and the system is a Debian (or Debian-derived) system. The trick here is to use `dpkg-buildpackage -a $deb_arch`. We also need to disable a few `debian/rules` that we don't actually need anyway. Closes ooni/probe#1741.
bassosimone
added a commit
that referenced
this pull request
Oct 22, 2021
In ooni/probe#1741, we observed that every attempt to use `docker --platform` along with `debian` for packaging ooniprobe fails with `SEGFAULT`, except when using the `debian:oldstable` container. To fix this issue, in this diff we fix Debian packaging to run on any debian system (`debian:stable` in our case) provided that we have `qemu-user-static` installed on the system and the system is a Debian (or Debian-derived) system. The trick here is to use `dpkg-buildpackage -a $deb_arch`. We also need to disable a few `debian/rules` that we don't actually need anyway. Closes ooni/probe#1741. This cherry-picks 36a5bf3 from the stable branch into the master branch.
bassosimone
added a commit
that referenced
this pull request
Oct 22, 2021
In ooni/probe#1741, we observed that every attempt to use `docker --platform` along with `debian` for packaging ooniprobe fails with `SEGFAULT`, except when using the `debian:oldstable` container. To fix this issue, in this diff we fix Debian packaging to run on any debian system (`debian:stable` in our case) provided that we have `qemu-user-static` installed on the system and the system is a Debian (or Debian-derived) system. The trick here is to use `dpkg-buildpackage -a $deb_arch`. We also need to disable a few `debian/rules` that we don't actually need anyway. Closes ooni/probe#1741. This cherry-picks 36a5bf3 from the stable branch into the master branch.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
In ooni/probe#1741, we observed that every attempt to use `docker --platform` along with `debian` for packaging ooniprobe fails with `SEGFAULT`, except when using the `debian:oldstable` container. To fix this issue, in this diff we fix Debian packaging to run on any debian system (`debian:stable` in our case) provided that we have `qemu-user-static` installed on the system and the system is a Debian (or Debian-derived) system. The trick here is to use `dpkg-buildpackage -a $deb_arch`. We also need to disable a few `debian/rules` that we don't actually need anyway. Closes ooni/probe#1741. This cherry-picks 41a01e26ab1caaf00aba1e307a7553d617b75e4c from the stable branch into the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Location of the issue tracker: https://github.com/ooni/probe
Description
In ooni/probe#1741, we observed that
every attempt to use
docker --platformalong withdebianforpackaging ooniprobe fails with
SEGFAULT, except when usingthe
debian:oldstablecontainer.To fix this issue, in this diff we fix Debian packaging to run on
any debian system (
debian:stablein our case) provided that wehave
qemu-user-staticinstalled on the system and the system isa Debian (or Debian-derived) system.
The trick here is to use
dpkg-buildpackage -a $deb_arch. Wealso need to disable a few
debian/rulesthat we don't actuallyneed anyway.
Closes ooni/probe#1741.