fix(netxlite): remove android-specific errno #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android is also Linux. The Android build fails because both errno_linux.go and errno_android.go are compiled. There's no difference between the files except into a comment that mentions "linux" or "android". Therefore, it's safe to remove the android-specific file and just keep and use the linux-specific one. Part of ooni/probe#1863, where we're forward porting ooni/go patches to go1.17. I'm still trying to figure out whether I can build oonimkall using the forward ported patches and this error prevents me from building, because the build fails. "やれやれだぜ" Note that this patch WILL need to be forward ported to master. This bug was previosuly reported to me by @hellais. Because I did run `go generate ./internal/netxlite/...` we also get for free updated certificates, which is OK.
bassosimone
added a commit
that referenced
this pull request
Nov 10, 2021
This commit forward ports 74947db from the `release/3.11` branch to `master`. Here's the original commit message: - - - Android is also Linux. The Android build fails because both errno_linux.go and errno_android.go are compiled. There's no difference between the files except into a comment that mentions "linux" or "android". Therefore, it's safe to remove the android-specific file and just keep and use the linux-specific one. Part of ooni/probe#1863, where we're forward porting ooni/go patches to go1.17. I'm still trying to figure out whether I can build oonimkall using the forward ported patches and this error prevents me from building, because the build fails. "やれやれだぜ" Note that this patch WILL need to be forward ported to master. This bug was previosuly reported to me by @hellais. Because I did run `go generate ./internal/netxlite/...` we also get for free updated certificates, which is OK.
bassosimone
added a commit
that referenced
this pull request
Nov 10, 2021
This commit forward ports 74947db from the `release/3.11` branch to `master`. Here's the original commit message: - - - Android is also Linux. The Android build fails because both errno_linux.go and errno_android.go are compiled. There's no difference between the files except into a comment that mentions "linux" or "android". Therefore, it's safe to remove the android-specific file and just keep and use the linux-specific one. Part of ooni/probe#1863, where we're forward porting ooni/go patches to go1.17. I'm still trying to figure out whether I can build oonimkall using the forward ported patches and this error prevents me from building, because the build fails. "やれやれだぜ" Note that this patch WILL need to be forward ported to master. This bug was previosuly reported to me by @hellais. Because I did run `go generate ./internal/netxlite/...` we also get for free updated certificates, which is OK.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
…ooni#587) This commit forward ports 50ff5f7f60eae344153a0ffb99a53f15b6a974cd from the `release/3.11` branch to `master`. Here's the original commit message: - - - Android is also Linux. The Android build fails because both errno_linux.go and errno_android.go are compiled. There's no difference between the files except into a comment that mentions "linux" or "android". Therefore, it's safe to remove the android-specific file and just keep and use the linux-specific one. Part of ooni/probe#1863, where we're forward porting ooni/go patches to go1.17. I'm still trying to figure out whether I can build oonimkall using the forward ported patches and this error prevents me from building, because the build fails. "やれやれだぜ" Note that this patch WILL need to be forward ported to master. This bug was previosuly reported to me by @hellais. Because I did run `go generate ./internal/netxlite/...` we also get for free updated certificates, which is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android is also Linux. The Android build fails because both
errno_linux.go and errno_android.go are compiled.
There's no difference between the files except into a comment
that mentions "linux" or "android".
Therefore, it's safe to remove the android-specific file
and just keep and use the linux-specific one.
Part of ooni/probe#1863, where we're
forward porting ooni/go patches to go1.17.
I'm still trying to figure out whether I can build oonimkall
using the forward ported patches and this error prevents me
from building, because the build fails.
"やれやれだぜ"
Note that this patch WILL need to be forward ported to master.
This bug was previosuly reported to me by @hellais.
Because I did run
go generate ./internal/netxlite/...we alsoget for free updated certificates, which is OK.
Checklist