chore: use go1.17.3 #588
Merged
chore: use go1.17.3 #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android is also Linux. The Android build fails because both errno_linux.go and errno_android.go are compiled. There's no difference between the files except into a comment that mentions "linux" or "android". Therefore, it's safe to remove the android-specific file and just keep and use the linux-specific one. Part of ooni/probe#1863, where we're forward porting ooni/go patches to go1.17. I'm still trying to figure out whether I can build oonimkall using the forward ported patches and this error prevents me from building, because the build fails. "やれやれだぜ" Note that this patch WILL need to be forward ported to master. This bug was previosuly reported to me by @hellais. Because I did run `go generate ./internal/netxlite/...` we also get for free updated certificates, which is OK.
- ensure we use go1.17.3 in workflows - update to a version of ooni/oohttp that uses go1.17.3 This change WILL need to be forward ported to master. Closes ooni/probe#1861
bassosimone
added a commit
that referenced
this pull request
Nov 10, 2021
This diff forward ports adcb0f9. Original commit message: - - - - ensure we use go1.17.3 in workflows - update to a version of ooni/oohttp that uses go1.17.3 This change WILL need to be forward ported to master. Closes ooni/probe#1861
bassosimone
added a commit
that referenced
this pull request
Nov 10, 2021
This diff forward ports adcb0f9. Original commit message: - - - - ensure we use go1.17.3 in workflows - update to a version of ooni/oohttp that uses go1.17.3 This change WILL need to be forward ported to master. Closes ooni/probe#1861
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
This diff forward ports a01ff0bec530bb78adc68c8d1c475c3e69b3a92e. Original commit message: - - - - ensure we use go1.17.3 in workflows - update to a version of ooni/oohttp that uses go1.17.3 This change WILL need to be forward ported to master. Closes ooni/probe#1861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
ensure we use go1.17.3 in workflows
update to a version of ooni/oohttp that uses go1.17.3
This change WILL need to be forward ported to master.
Closes ooni/probe#1861