cleanup: mark more integration tests as !short mode #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
commented
May 24, 2022
| @@ -1,37 +0,0 @@ | |||
| package ooapi_test | |||
There was a problem hiding this comment.
This example alone took 15' of runtime.
bassosimone
commented
May 24, 2022
| @@ -47,29 +43,6 @@ func TestNewSessionWithInvalidStateDir(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestMaybeUpdateResourcesWithCancelledContext(t *testing.T) { | |||
There was a problem hiding this comment.
Here we were testing a deprecated function that always returns nil.
Checking for every commit on master or on a release branch is good enough and makes pull requests faster than one minute since netxlite for windows is now 1m slower than coverage.
This should further reduce the runtime and expose more packages in which coverage comes from integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective is to make PR checks run much faster.
See ooni/probe#2113 for context.
Regarding netxlite's tests:
Checking for every commit on master or on a release branch is
good enough and makes pull requests faster than one minute since
netxlite for windows is now 1m slower than coverage.
We're losing some coverage but coverage from integration tests
is not so good anyway, so I'm not super sad about this loss.