cleanup: merge httpheader and httpfailure into model #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two small packages could easily be merged into the model package, since they're clearly model-like packages. Part of ooni/probe#2115
bassosimone
added a commit
to ooni/probe
that referenced
this pull request
May 25, 2022
bassosimone
commented
May 25, 2022
| @@ -21,7 +20,7 @@ func cloudflareIPLookup( | |||
| BaseURL: "https://www.cloudflare.com", | |||
| HTTPClient: httpClient, | |||
| Logger: logger, | |||
| UserAgent: httpheader.CLIUserAgent(), | |||
| UserAgent: model.HTTPHeaderUserAgent, | |||
There was a problem hiding this comment.
Here it was actually wrong to use the CLI user agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two small packages could easily be merged into the model
package, since they're clearly model-like packages.
Part of ooni/probe#2115