Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getaddrinfo: fix CGO_ENABLED=0 and record resolver type #765

Merged
merged 2 commits into from
May 30, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented May 29, 2022

After #764, the build for
CGO_ENABLED=0 has been broken for miniooni:

https://github.com/ooni/probe-cli/runs/6636995859?check_suite_focus=true

Likewise, it's not possible to run tests with CGO_ENABLED=0.

To make tests work with CGO_ENABLED=0, I needed to sacrifice some
unit tests run for the CGO case. It is not fully clear to me what was happening
here, but basically getaddrinfo_cgo_test.go was compiled with CGO
being disabled, even though the ``//go:build cgo` flag was specified.

Additionally, @hellais previously raised a valid point in the review
of #698:

Another issue we should consider is that, if I understand how
this works correctly, depending on whether or not we have built
with CGO_ENABLED=0 on or not, we are going to be measuring
things in a different way (using our cgo inspired getaddrinfo
implementation or using netgo). This might present issues when
analyzing or interpreting the data.

Do we perhaps want to add some field to the output data format that
gives us an indication of which DNS resolution code was used to
generate the the metric?

This comment is relevant to the current commit because
#698 is the previous
iteration of #764.

So, while fixing the build and test issues, let us also distinguish
between the CGO_ENABLED=1 and CGO_ENABLED=0 cases.

Before this commit, OONI used "system" to indicate the case where
we were using net.DefaultResolver. This behavior dates back to the
Measurement Kit days. While it is true that ooni/probe-engine and
ooni/probe-cli could have been using netgo in the past when we
said "system" as the resolver, it also seems reasonable to continue
to use "system" top indicate getaddrinfo.

So, the choice here is basically to use "netgo" from now on to
indicate the cases in which we were built with CGO_ENABLED=0.

This change will need to be documented into ooni/spec along with
the introduction of the android_dns_cache_no_data error.

Checklist

After #764, the build for
CGO_ENABLED=0 has been broken for miniooni:

https://github.com/ooni/probe-cli/runs/6636995859?check_suite_focus=true

Likewise, it's not possible to run tests with CGO_ENABLED=0.

Additionally, @hellais previously raised a valid point in the review
of #698:

> Another issue we should consider is that, if I understand how
> this works correctly, depending on whether or not we have built
> with CGO_ENABLED=0 on or not, we are going to be measuring
> things in a different way (using our cgo inspired getaddrinfo
> implementation or using netgo). This might present issues when
> analyzing or interpreting the data.
>
> Do we perhaps want to add some field to the output data format that
> gives us an indication of which DNS resolution code was used to
> generate the the metric?

This comment is relevant to the current commit because
#698 is the previous
iteration of #764.

So, while fixing the build and test issues, let us also distinguish
between the CGO_ENABLED=1 and CGO_ENABLED=0 cases.

Before this commit, OONI used "system" to indicate the case where
we were using net.DefaultResolver. This behavior dates back to the
Measurement Kit days. While it is true that ooni/probe-engine and
ooni/probe-cli could have been using netgo in the past when we
said "system" as the resolver, it also seems reasonable to continue
to use "system" top indicate getaddrinfo.

So, the choice here is basically to use "netgo" from now on to
indicate the cases in which we were built with CGO_ENABLED=0.

This change will need to be documented into ooni/spec along with
the introduction of the `android_dns_cache_no_data` error.
@bassosimone bassosimone requested a review from hellais as a code owner May 29, 2022 11:20
bassosimone added a commit to ooni/spec that referenced this pull request May 29, 2022
See ooni/probe-cli#765, where I identified
I needed to sync up spec with probe-cli.
bassosimone added a commit to ooni/spec that referenced this pull request May 30, 2022
See ooni/probe-cli#765, where I identified
I needed to sync up spec with probe-cli.

## Checklist

- [x] I have read the [contribution guidelines](https://github.com/ooni/spec/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request: ooni/probe#2029
- [x] related ooni/probe-cli pull request: ooni/probe-cli#765
- [x] If I changed a spec, I also bumped its version number and/or date
@bassosimone bassosimone merged commit f391218 into master May 30, 2022
@bassosimone bassosimone deleted the issue/2029-small branch May 30, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant