netxlite: do not call netgo the CGO_ENABLED=0 resolver #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ooni/probe#2029 (comment), we explained why calling it "netgo" would be incorrect. In other words, we can get the platform's `getaddrinfo` as long as we're not cross compiling. We do cross compile `ooniprobe`, actually it's not even possible to cross compile it. For increased accuracy, we should stop cross compiling `miniooni` as well, so it would also directly use `getaddrinfo`. This diff fixes at the same time ooni/probe-cli and ooni/spec and we'll open two pull requests in parallel.
|
[...]
I created ooni/probe#2119 to track this follow up work. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ooni/probe#2029 (comment), we
explained why calling it "netgo" would be incorrect.
In other words, we can get the platform's
getaddrinfoas long aswe're not cross compiling. We do cross compile
ooniprobe, actuallyit's not even possible to cross compile it.
For increased accuracy, we should stop cross compiling
minioonias well, so it would also directly use
getaddrinfo.This diff fixes at the same time ooni/probe-cli and ooni/spec
and we'll open two pull requests in parallel.