Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(engine): allow scripts to register experiments #860

Merged
merged 88 commits into from
Aug 17, 2022
Merged

refactor(engine): allow scripts to register experiments #860

merged 88 commits into from
Aug 17, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Aug 17, 2022 •
edited
Loading

Checklist

Description

N/A

@bassosimone
refactor: move Engine to the model pkg
71175a0 
This mechanical refactoring moves model.Engine to the model
package. This changce is functional to subsequent changes to
more easily generate and maintain existing experiments.
@bassosimone
refactor: move ExperimentBuild into the model package
b945278 
Like the previous commit, here the idea is to move things around
in a mechanical fashion before working on more substantial changes.
@bassosimone
refactor: unentangle experiment builder from engine
ce04ee2 
Here the idea is that the logic for creating an experiment lives in
internal/registry along with a list of experiments.

In turn, this design will allow us soon to make it very easy to add a
new experiment, by making each experiment register itself.

However, before doing that, I need to refactor the code so that
each experiment and the engine can both import from registry.

    +---------------+                 +--------+
    | An experiment |                _| engine |
    +---------------+               | +--------+
              |                     |
              |                     |
              |      +----------+   |
              `----->| registry |<--.  imports
          imports    +----------+

Once the above is possible, then each experiment can register itself.
@bassosimone
refactor(registry): one file for each experiment
9c9936d 
This design allows us to automatically add new experiments by
writing files in the proper package.
@bassosimone
feat: add script to generate experiment's boilerplate
ddf4f0e
@bassosimone
fix(boilerplate): run go fmt at the end
9211251
@bassosimone
fix(boilerplate): minor fixes
339057c
@bassosimone
boilerplate: more fixes and improvements
2027528
@bassosimone
boilerplate: some extra changes
cccb41c
@bassosimone
boilerplate: record one more TODO
eb39702
@bassosimone
fix(boilerplate): a bunch of minor fixes
2b99203
@bassosimone
feat: new boilerplate improvements
1cf7f0f
@bassosimone
boilerplate: split by type more aggressively
ba7a9c8
@bassosimone
fix: add files I forgot to commit
848f2aa
@bassosimone
feat(boilerplate): allow interrupting experiments
3052416
@bassosimone
boilerplate: add more explanatory code
5d41081
@bassosimone
boilerplate: last changes before asking for feedback
e6756dc
@bassosimone
fix(boilerplate): allow experiment names to contain underscore
04c759f
@bassosimone
fix docs
6c9018d
@bassosimone
progress
5f33f43
@bassosimone
subsequent changes to make it easier to manage
3845fbf
@bassosimone
Merge branch 'main' into feature/boilerplate
390ec74
@bassosimone
additional fixes
186b159
@bassosimone
chore: autogenerate boilerplate for telegram experiment
c55dabc
@bassosimone
fix: make sure we init the test keys
3dc30cb
@bassosimone
Start writing the telegram experiment
9af1400
@bassosimone
changes
1478318
@bassosimone
changes
7983b7b
@bassosimone
changes
9729b80
@bassosimone
x
3582e1d
@bassosimone
feat: add analysis code
8705d2f
@bassosimone
fix: make output easier to read
0b6c7d5
@bassosimone
fix: handle the dns_no_answer case for AAAA
6709c2b
@bassosimone
fix: remove bug added when trying to beautify output
388395f
@bassosimone
fix: improve logging and save more DoH data
c6e157a
@bassosimone
fix: only use TLS handshake for interesting addrs
844e36b
@bassosimone
fix: improve the way in which we log the final status
87f7300
@bassosimone
fix: move doh specific events into their hier
8e6ad18
@bassosimone
feat: also split do53 ancillary queries
665f0aa
@bassosimone
feat: implement detecting DNS interception
d378709
@bassosimone
feat: measure new IP addrs discovered by the TH
c62f08c
@bassosimone
feat: cycle through doh services to measure
35cc912 
Also, make it opportunistic rather than measuring each time.

So, we'll have some more measurements.
@bassosimone
mention one more todo
36c44e7
@bassosimone
fix: start extra measurements with parent ctx
9214c4b
@bassosimone
changes after code review
4f50590
@bassosimone
bugfix
429e46e
@bassosimone
refactor: make reprocessing from saved measurements ~possible
3075470
@bassosimone
Add internal tool to test the scoring rules
3567738
@bassosimone
sync templates and implementation
c9be163
@bassosimone
cleanup: remove the standalone system resolver
70482f9
@bassosimone
start removing code which shan't go in this PR
23cf192
@bassosimone
further reduce diff with main
8592c99
@bassosimone
Merge branch 'main' into issue/2216
4b83fb9
@bassosimone
further reduce useless diff
37e26b9
@bassosimone bassosimone marked this pull request as ready for review August 17, 2022 08:40
@bassosimone bassosimone requested a review from hellais as a code owner August 17, 2022 08:40
@bassosimone bassosimone merged commit 6a0ae5c into master Aug 17, 2022
@bassosimone bassosimone deleted the issue/2216 branch August 17, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone