Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oohelperd): measure TLS for :443 endpoints #886

Merged
merged 14 commits into from
Aug 28, 2022
Merged

feat(oohelperd): measure TLS for :443 endpoints #886

merged 14 commits into from
Aug 28, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Aug 27, 2022 •
edited
Loading

Checklist

Description

This pull request originally contained misc improvements to the TH that will allow us to collect better measurements. Even without deploying a new web connectivity, just the availability of this data in the results will increase clarity.

The plan is to go through these changes, format them as self-contained and fully tested patches and merge them.

After we've done that, we'll probably need to perform some canary testing of the new TH implementation.

We also need to create relevant issues for this work.

At the time of merging, most of the original context of this pull request was merged separately, such that, at the end, it only contained code for performing optional TLS measurements inside oohelperd.

@bassosimone
fix(oohelperd): enforce timeout for each measurement step
6510b61 
1. use a 4 seconds timeout for the DNS lookup;

2. use a 10 seconds timeout for TCP;

3. use a 15 seconds timeout for HTTP.
@bassosimone
refactor(oohelperd): wait for DNS before measuring endpoints
f247d6b 
This diff refactors the oohelperd such that we wait for the DNS to
complete before actually measuring endpoints.

This change will come in handy soon when we'll merge endpoints
provided by the client with endpoints resolved by the TH.
@bassosimone
refactor(oohelperd): make TCP-reading loop more robust
61efffd 
Rather than constraining on the expected maximum size, just
drain the channel until it becomes empty.
@bassosimone
feat(oohelperd): measure probe+th endpoints
0f782d3
@bassosimone
feat(oohelperd): optionally perform TLS handshakes
cffcee6
@bassosimone
feat(oohelperd): geolookup all addresses
3b3e155
@bassosimone
fix(oohelperd): by default listen on localhost
da37230
@bassosimone
bunch of extra fixes
0a43d91
@bassosimone
refactor: return to probe higher quality IP info
7543eea
@bassosimone
feat: report whether an address is valid for the domain
8998a92
@bassosimone
Merge branch 'main' into betterth
3eb7f64 
Conflicts:
	internal/cmd/oohelperd/measure.go
	internal/cmd/oohelperd/tcpconnect.go
@bassosimone
Merge branch 'main' into betterth
66b500a 
Conflicts:
	internal/cmd/oohelperd/ipinfo.go
	internal/cmd/oohelperd/measure.go
	internal/cmd/oohelperd/tcpconnect.go
	internal/engine/experiment/webconnectivity/control.go
@bassosimone
x
b5e0411
@bassosimone
x
6acb092
@bassosimone bassosimone changed the title Betterth feat(oohelperd): introduce TLS measurements Aug 28, 2022
@bassosimone bassosimone changed the title feat(oohelperd): introduce TLS measurements feat(oohelperd): measure TLS for :443 endpoints Aug 28, 2022
@bassosimone bassosimone marked this pull request as ready for review August 28, 2022 12:33
@bassosimone bassosimone requested a review from hellais as a code owner August 28, 2022 12:33
@bassosimone bassosimone merged commit 1e7384d into master Aug 28, 2022
@bassosimone bassosimone deleted the betterth branch August 28, 2022 12:34
@bassosimone bassosimone mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone