Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to make linux builds faster #911

Merged
merged 17 commits into from
Aug 30, 2022
Merged

fix: attempt to make linux builds faster #911

merged 17 commits into from
Aug 30, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Aug 30, 2022

This work aims to make Linux builds faster to make ooni/probe#2249 more convenient. Since those builds runs inside Docker, the problem to solve here is to save/restore the Go caches notwithstanding Docker. Because Docker runs as root, we need to modify the build a bit to run as a normal user. Otherwise, we will not be able to save the Go cache using actions/cache@v3. (Other approaches such as using sudo are possible but running the build as an unprivileged user actually looks cleaner, so I chose to do that.) While there, add a .editorconfig.

@bassosimone bassosimone requested a review from hellais as a code owner August 30, 2022 14:03
@bassosimone bassosimone merged commit 196ac55 into master Aug 30, 2022
@bassosimone bassosimone deleted the linuxbuild branch August 30, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant