Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(miniooni): optionally log using emojis #932

Merged
merged 3 commits into from
Sep 5, 2022
Merged

feat(miniooni): optionally log using emojis #932

merged 3 commits into from
Sep 5, 2022

Conversation

bassosimone
Copy link
Contributor

As silly as it seems, emojis help a lot when eyeballing logs
to quickly identify unexpected lines.

I'm doing this work as part of ooni/probe#2257

@bassosimone
feat(miniooni): optionally log using emojis
4f105a1 
As silly as it seems, emojis help _a lot_ when eyeballing logs
to quickly identify unexpected lines.

I'm doing this work as part of ooni/probe#2257
@bassosimone
no need to export DiscardLogger from logx for now
1bf6d5c
@bassosimone bassosimone requested a review from hellais as a code owner September 5, 2022 07:57
bassosimone
bassosimone commented Sep 5, 2022
View reviewed changes
internal/logx/logx.go Outdated Show resolved Hide resolved
bassosimone
bassosimone commented Sep 5, 2022
View reviewed changes
internal/logx/logx.go Outdated Show resolved Hide resolved
@bassosimone bassosimone merged commit 34dc029 into master Sep 5, 2022
@bassosimone bassosimone deleted the issue/2257 branch September 5, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone