fix(webconnectivity@v0.5): include http transaction start/done #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code based on urlgetter had this event and we would like to have this event with step-by-step code as well. Because there's no tracing for HTTP when using step-by-step, we will need to include emitting these events inside the boilerplate. By doing that, we emit events out of order, so make sure we sort them by T, which is "the moment when the event was collected". Part of ooni/probe#2238
bassosimone
added a commit
that referenced
this pull request
Sep 8, 2022
…done (#943) Code based on urlgetter had this event and we would like to have this event with step-by-step code as well. Because there's no tracing for HTTP when using step-by-step, we will need to include emitting these events inside the boilerplate. By doing that, we emit events out of order, so make sure we sort them by T, which is "the moment when the event was collected". Part of ooni/probe#2238
bassosimone
added a commit
that referenced
this pull request
Sep 8, 2022
We're bumping the version number to reflect recent improvements in the data format implemented in these pull requests: - #942 - #943 - #944 Reference issue: ooni/probe#2238
bassosimone
added a commit
that referenced
this pull request
Sep 8, 2022
chore: web_connectivity v0.5.5 We're bumping the version number to reflect recent improvements in the data format implemented in these pull requests: - #942 - #943 - #944 Reference issue: ooni/probe#2238
bassosimone
added a commit
that referenced
this pull request
Sep 8, 2022
chore: web_connectivity v0.5.5 We're bumping the version number to reflect recent improvements in the data format implemented in these pull requests: - #942 - #943 - #944 Reference issue: ooni/probe#2238
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code based on urlgetter had this event and we would like to have this event with step-by-step code as well.
Because there's no tracing for HTTP when using step-by-step, we will need to include emitting these events inside the boilerplate.
By doing that, we emit events out of order, so make sure we sort them by T, which is "the moment when the event was collected".
Part of ooni/probe#2238