Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS dependency added to some E2E tests #245

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

OS dependency added to some E2E tests #245

wants to merge 6 commits into from

Conversation

Eddges
Copy link
Contributor

@Eddges Eddges commented Aug 14, 2021

  • Onboarding Story 1 and 2 now made independent
  • Autorun prompt covered in tests for MacOS and Windows
  • App now resets data after final e2e test is performed, so it doesn't fail every alternate time.

@Eddges Eddges requested a review from sarathms August 14, 2021 15:10
@Eddges Eddges closed this Aug 14, 2021
@Eddges Eddges reopened this Aug 14, 2021
@Eddges Eddges mentioned this pull request Aug 20, 2021
Closed
sarathms
sarathms approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@sarathms sarathms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine to me. As a future improvement we could maybe figure out ways to reduce possible duplication of test code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarathms sarathms sarathms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddges @sarathms