Sign ooniprobe.exe during build #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellais
reviewed
Feb 15, 2024
| execSync( | ||
| `osslsigncode sign -pkcs12 ${process.env.WIN_CSC_LINK} -pass ${process.env.WIN_CSC_KEY_PASSWORD} -n "OONI Probe CLI" -i https://ooni.org/ -in ${dstDir}/${osarch}/ooniprobe${extension}-unsigned -out ${dstDir}/${osarch}/ooniprobe${extension}` | ||
| ) | ||
| execSync(`rm -rf ${dstDir}/${osarch}/ooniprobe${extension}-unsigned`) |
There was a problem hiding this comment.
Maybe add an assert that dstDir and osarch are longer than some length to prevent unintended rm -rf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ooni/probe#2683
I was able to reproduce the issue with windows 11 running on UTM. Windows Defender also raised an alarm when downloading unsigned ooniprobe.exe on it's own - also marking it as a Trojan.
Probe desktop with signed ooniprobe.exe is working as expected on my UTM instance.