Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experiment/sni_blocking: rewrite using urlgetter #684

Closed
1 task
bassosimone opened this issue Jun 9, 2020 · 1 comment
Closed
1 task

experiment/sni_blocking: rewrite using urlgetter #684

bassosimone opened this issue Jun 9, 2020 · 1 comment
Assignees
@bassosimone
Labels
effort/M Medium effort priority/medium Medium priority
Milestone
Sprint 16 - Neon

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Jun 9, 2020 •
edited
Loading

Following up from #646

  • reimplement experiment/sni_blocking in terms of experiment/urlgetter

This refactoring is functional to measure performance metrics. In turn, by doing that we will be able to measure HTTP fetching performance metrics for Psiphon. This is also a precondition to rewrite Web Connectivity in Go.
@bassosimone bassosimone added this to the Sprint 16 - Neon milestone Jun 9, 2020
@bassosimone bassosimone self-assigned this Jun 9, 2020
@bassosimone bassosimone mentioned this issue Jun 9, 2020
Closed
3 tasks
@bassosimone bassosimone added effort/XL Extra large effort priority/medium Medium priority effort/M Medium effort and removed effort/XL Extra large effort labels Jun 22, 2020
@bassosimone bassosimone changed the title Netx research and refactoring in Sprint 16 experiment/sni_blocking: rewrite using urlgetter Jun 22, 2020
bassosimone added a commit that referenced this issue Jul 1, 2020
@bassosimone
sniblocking: rewrite using urlgetter
d20db52 
A more substantial rewrite would have been possible. But let's proceed
piecemeal and, for now, just stop depending on the old netx.

This was the objective and we achieved it.

When we'll tackle the task of improving testing, we'll also refactor
the tests and see if we can also simplify sniblocking further.

Part of #684
@bassosimone bassosimone mentioned this issue Jul 1, 2020
Merged
bassosimone added a commit that referenced this issue Jul 1, 2020
@bassosimone
sniblocking: add missing THAddress spotted during code review
68dcf88 
This is part of #684
bassosimone added a commit that referenced this issue Jul 1, 2020
@bassosimone
sniblocking: start improving the quality of unit tests
d3b8a89 
Part of #684
bassosimone added a commit that referenced this issue Jul 1, 2020
@bassosimone
sniblocking: clarify what happens and add one more test
264636c 
This gives us confidence that we obtain the right result even when we
are failing before even starting the experiment.

Part of #684.
bassosimone added a commit that referenced this issue Jul 1, 2020
@bassosimone
sniblocking: interrupted is a more proper error here
7f158ed 
When the experiment was written, we didn't have this error. Now that we
have it, we should use it, because it's more proper.

Part of #684
bassosimone added a commit that referenced this issue Jul 1, 2020
@bassosimone
sniblocking: also specify the failed operation
d9926fe 
This is more consistent.

Part of #684
bassosimone added a commit that referenced this issue Jul 1, 2020
@bassosimone
sniblocking: rewrite using urlgetter (#744)
23c1f10 
* sniblocking: rewrite using urlgetter

A more substantial rewrite would have been possible. But let's proceed
piecemeal and, for now, just stop depending on the old netx.

This was the objective and we achieved it.

When we'll tackle the task of improving testing, we'll also refactor
the tests and see if we can also simplify sniblocking further.

Part of #684

* sniblocking: further simplify using more urlgetter goodies

* sniblocking: add missing THAddress spotted during code review

This is part of #684

* sniblocking: start improving the quality of unit tests

Part of #684

* sniblocking: clarify what happens and add one more test

This gives us confidence that we obtain the right result even when we
are failing before even starting the experiment.

Part of #684.

* sniblocking: interrupted is a more proper error here

When the experiment was written, we didn't have this error. Now that we
have it, we should use it, because it's more proper.

Part of #684

* sniblocking: also specify the failed operation

This is more consistent.

Part of #684
@bassosimone
Copy link
Contributor Author

This task has been completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
effort/M Medium effort priority/medium Medium priority
Projects
None yet
Milestone
Sprint 16 - Neon
Development

No branches or pull requests
1 participant
@bassosimone