Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new tor experiment #227

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Implement the new tor experiment #227

merged 5 commits into from
Jan 23, 2020

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Jan 12, 2020

Closes #226 and #276

experiment/tor/tor.go Outdated Show resolved Hide resolved
experiment/tor/tor.go Outdated Show resolved Hide resolved
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few pretty minor comments in here, for the rest it looks good to me!

I would say it's probably most useful we discuss the details of this inside of spec PR: ooni/spec#175

@hellais hellais added the ooni/probe-engine Issues related to github.com/ooni/probe-engine label Jan 16, 2020
@bassosimone bassosimone requested a review from hellais January 22, 2020 16:24
@bassosimone bassosimone merged commit 0728ce5 into master Jan 23, 2020
@bassosimone bassosimone deleted the feature/orchestra-tor branch January 23, 2020 16:31
@bassosimone bassosimone mentioned this pull request Jan 23, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ooni/probe-engine Issues related to github.com/ooni/probe-engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tor experiment (episode 1)
3 participants