iplookup: remove akamai IP lookup method #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems we cannot access this service without using domain fronting and we need to use the a248.e.akamai.net SNI to get a valid certificate. So, I don't want to make this fix more complicated than it needs to be. We will remove this IP lookup method and hopefully OONI will work better. Closes #317. I also don't feel super guilty in removing one lookup method we have an issue to add more: https://github.com/ooni/probe-engine/issues/16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we cannot access this service without using domain
fronting and we need to use the a248.e.akamai.net SNI to get
a valid certificate. So, I don't want to make this fix more
complicated than it needs to be. We will remove this IP lookup
method and hopefully OONI will work better.
Closes #317.
I also don't feel super guilty in removing one lookup method
we have an issue to add more: https://github.com/ooni/probe-engine/issues/16