Introduce a caching DNS resolver #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no cache aging. If a resolution is successful, then we do cache the result. This is meant as a mechanism to make measurements faster and with less data points. For this reason it's disabled by default. Consider for example the case where `http://www.example.com` redirects you to `https://www.example.com`. You really don't want to perform the name resolution again in this case. As a side note, depending on the resolver we're using, we may not need the caching mechanism. Nonetheless, using the cache always when measuring also reduces the number of duplicate entries we produce where only the first entry has actually been resolved. This was developed as part of #509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no cache aging. If a resolution is successful, then we
do cache the result. This is meant as a mechanism to make measurements
faster and with less data points. For this reason it's disabled by
default. Consider for example the case where
http://www.example.comredirects you to
https://www.example.com. You really don't wantto perform the name resolution again in this case.
As a side note, depending on the resolver we're using, we may not
need the caching mechanism. Nonetheless, using the cache always when
measuring also reduces the number of duplicate entries we produce
where only the first entry has actually been resolved.
This was developed as part of #509