QA(webconnectivity): make sure output matches MK #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted while comparing with Measurement Kit. Part of #810.
According to the implementations, the semantics is that blocking is false when accessible is true, a nullable string otherwise. The diff documents in detail how and why this was introduced. It would probably have been better to not make this field semantics so complicate, but now it's too late. Maybe in the future we can have some extra field with a more clear and simple semantics? Part of #810
bassosimone
added a commit
to ooni/spec
that referenced
this pull request
Aug 13, 2020
Part of ooni/probe-engine#810. See ooni/probe-engine#839 for explanation.
bassosimone
added a commit
to ooni/spec
that referenced
this pull request
Aug 13, 2020
#200) Part of ooni/probe-engine#810. See ooni/probe-engine#839 for explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #810