Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resourcesmanager: we don't need to copy resources #1372

Closed
bassosimone opened this issue Mar 4, 2021 · 0 comments
Closed

resourcesmanager: we don't need to copy resources #1372

bassosimone opened this issue Mar 4, 2021 · 0 comments
Assignees
@bassosimone
Labels
bug Something isn't working priority/low
Milestone
Sprint 36 - Rhodo...

Comments

@bassosimone
Copy link
Contributor

See https://pkg.go.dev/github.com/oschwald/geoip2-golang#FromBytes
@bassosimone bassosimone added bug Something isn't working triage labels Mar 4, 2021
@bassosimone bassosimone added this to the Sprint 34 - Hapi milestone Mar 4, 2021
@bassosimone bassosimone self-assigned this Mar 4, 2021
bassosimone added a commit to ooni/probe-assets that referenced this issue Mar 31, 2021
@bassosimone
fix: export bytes directly and add tests
6b90848 
It's more convenient to export the compressed bytes directly. It is also
quite useful to have a basic smoke test in place.

Part of ooni/probe#1372
bassosimone added a commit to ooni/probe-cli that referenced this issue Mar 31, 2021
@bassosimone
feat: use embedded geoip databases
600a255 
Closes ooni/probe#1372.

Work done as part of ooni/probe#1369.
@bassosimone bassosimone mentioned this issue Apr 1, 2021
Merged
ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
refactor: redesign how we import assets (ooni#260)
4bd670f 
* fix(pkg.go.dev): import a subpackage containing the assets

We're trying to fix this issue that pkg.go.dev does not build.

Thanks to @hellais for this very neat idea! Let's keep our
fingers crossed and see whether it fixes!

* feat: use embedded geoip databases

Closes ooni/probe#1372.

Work done as part of ooni/probe#1369.

* fix(assetsx): add tests

* feat: simplify and just vendor uncompressed DBs

* remove tests that seems not necessary anymore

* fix: run go mod tidy

* Address https://github.com/ooni/probe-cli/pull/260/files#r605181364

* rewrite a test in a better way

* fix: gently cleanup the legacy assetsdir

Do not remove the whole directory with brute force. Just zap the
files whose name we know. Then attempt to delete the legacy directory
as well. If not empty, just fail. This is fine because it means the
user has stored other files inside the directory.

* fix: create .miniooni if missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working priority/low
Projects
None yet
Milestone
Sprint 36 - Rhodophyta
Development

No branches or pull requests
1 participant
@bassosimone