Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: disable maxRuntime w/o web_connectivity #1433

Closed
bassosimone opened this issue Apr 6, 2021 · 2 comments
Closed

cli: disable maxRuntime w/o web_connectivity #1433

bassosimone opened this issue Apr 6, 2021 · 2 comments
Assignees
@bassosimone
Labels
bug Something isn't working correctly interrupt priority/high Important issue that needs attention soon
Milestone
Sprint 36 - Rhodo...

Comments

@bassosimone
Copy link
Contributor

Otherwise the progress status report is broken when running any other nettest.

Reported by @sarathms. Affects 3.9.0.
@bassosimone bassosimone added bug Something isn't working correctly priority/high Important issue that needs attention soon effort/XS interrupt labels Apr 6, 2021
@bassosimone bassosimone added this to the Sprint 36 - Rhodophyta milestone Apr 6, 2021
@bassosimone bassosimone self-assigned this Apr 6, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 6, 2021
@bassosimone
fix: disable maxRuntime when not WebConnectivity
6306c09 
See ooni/probe#1433
@bassosimone bassosimone mentioned this issue Apr 6, 2021
Closed
@bassosimone
Copy link
Contributor Author

See also #1434

bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 6, 2021
@bassosimone
fix: disable maxRuntime when not WebConnectivity
6664ee4 
This commit cherry-picks 6306c09

See ooni/probe#1433

Conflicts:
	internal/version/version.go
@bassosimone bassosimone mentioned this issue Apr 6, 2021
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 6, 2021
@bassosimone
fix: disable maxRuntime when not WebConnectivity (#302)
46d19f4 
This commit cherry-picks 6306c09

See ooni/probe#1433

Conflicts:
	internal/version/version.go
@bassosimone
Copy link
Contributor Author

Fixed!

ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
fix: disable maxRuntime when not WebConnectivity
f8f96c6 
See ooni/probe#1433
ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
fix: disable maxRuntime when not WebConnectivity (ooni#302)
3944ddb 
This commit cherry-picks ooni@6306c09

See ooni/probe#1433

Conflicts:
	internal/version/version.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working correctly interrupt priority/high Important issue that needs attention soon
Projects
None yet
Milestone
Sprint 36 - Rhodophyta
Development

No branches or pull requests
1 participant
@bassosimone