Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.9.1: disable maxRuntime with user-provided input #1436

Closed
bassosimone opened this issue Apr 7, 2021 · 2 comments
Closed

3.9.1: disable maxRuntime with user-provided input #1436

bassosimone opened this issue Apr 7, 2021 · 2 comments
Assignees
@bassosimone
Labels
bug Something isn't working interrupt priority/high
Milestone
Sprint 36 - Rhodo...

Comments

@bassosimone
Copy link
Contributor

When the user is using --input or --input-file, they probably want to test the whole list rather than hitting a timeout enforced by the timed runs where we fetch data from the API. (We have too many running modes and options combination. We need to do something to restructure the code so that what happens is obvious and we have less ifs.)
@bassosimone bassosimone added this to the Sprint 36 - Rhodophyta milestone Apr 7, 2021
@bassosimone bassosimone self-assigned this Apr 7, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 7, 2021
@bassosimone
fix: disable maxRuntime with --input or --input-file
b7f2ecb 
When this happens, the user is expressing the intention of
explicitly testing all the input they provided.

So, disable maxRuntime in these cases.

Part of ooni/probe#1436.
@bassosimone bassosimone mentioned this issue Apr 7, 2021
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 7, 2021
@bassosimone
fix: disable maxRuntime with --input or --input-file (#305)
4578df0 
When this happens, the user is expressing the intention of
explicitly testing all the input they provided.

So, disable maxRuntime in these cases.

Part of ooni/probe#1436.
@bassosimone
Copy link
Contributor Author

Fixed at ooni/probe-cli#305. We still probably need to backport to 3.9.2.

bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 7, 2021
@bassosimone
fix: disable maxRuntime with --input or --input-file (#305)
c5f52d5 
When this happens, the user is expressing the intention of
explicitly testing all the input they provided.

So, disable maxRuntime in these cases.

Part of ooni/probe#1436.
@bassosimone
Copy link
Contributor Author

With ooni/probe-cli#308 we ensure we're not losing this fix from the stable branch.

ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
fix: disable maxRuntime with --input or --input-file (ooni#305)
c70ffb0 
When this happens, the user is expressing the intention of
explicitly testing all the input they provided.

So, disable maxRuntime in these cases.

Part of ooni/probe#1436.
ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
fix: disable maxRuntime with --input or --input-file (ooni#305)
1c4649e 
When this happens, the user is expressing the intention of
explicitly testing all the input they provided.

So, disable maxRuntime in these cases.

Part of ooni/probe#1436.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working interrupt priority/high
Projects
None yet
Milestone
Sprint 36 - Rhodophyta
Development

No branches or pull requests
1 participant
@bassosimone