Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: migrate to go1.17 #1738

Closed
bassosimone opened this issue Aug 18, 2021 · 2 comments
Closed

cli: migrate to go1.17 #1738

bassosimone opened this issue Aug 18, 2021 · 2 comments
Assignees
@bassosimone
Labels
epic priority/medium

Comments

@bassosimone
Copy link
Contributor

No description provided.

@bassosimone bassosimone self-assigned this Aug 18, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 18, 2021
@bassosimone
coverage: start using also go1.17
17bd466 
This is part of the migration from go1.16 go go1.17.

Reference issue: ooni/probe#1738
@bassosimone bassosimone mentioned this issue Aug 18, 2021
Merged
3 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 18, 2021
@bassosimone
coverage: start using also go1.17 (#440)
21a2b31 
This is part of the migration from go1.16 go go1.17.

Reference issue: ooni/probe#1738
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 18, 2021
@bassosimone
coverage: start using also go1.17
1e4fed6 
This is part of the migration from go1.16 go go1.17.

Reference issue: ooni/probe#1738

This is a cherry-pick of 21a2b31
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 18, 2021
@bassosimone
fix(workflows): enable more checks in the stable branch
a53ad8d 
Part of ooni/probe#1738
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 18, 2021
@bassosimone
fix: use h3 instead of h3-29 in tests
fa2b08d 
It seems the new lucas-clemente/quic-go does not support h3-29 anymore.

Reference issue: ooni/probe#1738
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 18, 2021
@bassosimone
fix(workflows): enable more checks in the stable branch
f0d05c5 
Part of ooni/probe#1738
@bassosimone bassosimone mentioned this issue Aug 18, 2021
Closed
3 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 5, 2021
@bassosimone
fix: only run coverage using go1.17
b2085fe 
This is the version of Go with which we are going to bless v3.11.0
therefore it's the only version of Go that matters.

Reference issue: ooni/probe#1738.
@bassosimone bassosimone mentioned this issue Sep 5, 2021
Merged
3 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 5, 2021
@bassosimone
ci: master only runs coverage and only with go1.17 (+ fix flaky test) (…
f0927ea 
…#452)

* fix: disable debianrepo build on master branch

This just mitigates ooni/probe#1741 and does
not fully address it, but I'd rather avoid delving into this problem until
I open a release/v3.11.0 branch and have to really fix this issue.

* fix: only run coverage using go1.17

This is the version of Go with which we are going to bless v3.11.0
therefore it's the only version of Go that matters.

Reference issue: ooni/probe#1738.

* fix(ptx/obfs4_test.go): avoid context-vs-normal-code race

We want to test whether we get the context failure if the error
generated inside normal code happens _after_ the context cancellation.

The best way to do that is to write code that is not racy. To this
end, we just need to pause normal code until we know that the context
has returned to the caller. We also need to ensure we do not leak
a goroutine, hence we use a WaitGroup to check that.

Fixes ooni/probe#1750
@bassosimone
Copy link
Contributor Author

Move to Sprint 48.

@bassosimone
Copy link
Contributor Author

I think the immediate emergency has been addressed. We can now continue working in a more normal fashion addressing problem as they occur as part of the normal release workflow.

ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
coverage: start using also go1.17 (ooni#440)
93613b3 
This is part of the migration from go1.16 go go1.17.

Reference issue: ooni/probe#1738
ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
ci: master only runs coverage and only with go1.17 (+ fix flaky test) (…
428fc66 
…ooni#452)

* fix: disable debianrepo build on master branch

This just mitigates ooni/probe#1741 and does
not fully address it, but I'd rather avoid delving into this problem until
I open a release/v3.11.0 branch and have to really fix this issue.

* fix: only run coverage using go1.17

This is the version of Go with which we are going to bless v3.11.0
therefore it's the only version of Go that matters.

Reference issue: ooni/probe#1738.

* fix(ptx/obfs4_test.go): avoid context-vs-normal-code race

We want to test whether we get the context failure if the error
generated inside normal code happens _after_ the context cancellation.

The best way to do that is to write code that is not racy. To this
end, we just need to pause normal code until we know that the context
has returned to the caller. We also need to ensure we do not leak
a goroutine, hence we use a WaitGroup to check that.

Fixes ooni/probe#1750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
epic priority/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bassosimone @hellais