Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ooapi: renable tests we currently skip #1790

Closed
bassosimone opened this issue Sep 29, 2021 · 1 comment
Closed

ooapi: renable tests we currently skip #1790

bassosimone opened this issue Sep 29, 2021 · 1 comment
Assignees
@bassosimone
Labels
ooni/probe-engine priority/low wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)

Comments

@bassosimone
Copy link
Contributor

I am about to disable always-failing tests, which require fixes in ooni/backend to work. As long as we don't use the ooapi for speaking with out backend, it's fine to keep these tests disabled. Currently, they are just annoying noise.
@bassosimone bassosimone self-assigned this Sep 29, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 29, 2021
@bassosimone
fix(ooapi): disable tests we're not using
2a314db 
At the moment ooapi is not used. It will eventually be used since
it's a better way of accessing the OONI backend API.

To fix these tests, we need to fix the swagger emitted by the
backend API, which is not a priority at the moment, since we are
working instead to integrate websteps in miniooni.

Issue ooni/probe#1790 tracks the work
required to re-enabled the tests I'm skipping with this diff.

This work is part of ooni/probe#1733.
@bassosimone bassosimone mentioned this issue Sep 29, 2021
Merged
3 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 29, 2021
@bassosimone
fix(ooapi): disable tests we're not using (#525)
24a6ac9 
At the moment ooapi is not used. It will eventually be used since
it's a better way of accessing the OONI backend API.

To fix these tests, we need to fix the swagger emitted by the
backend API, which is not a priority at the moment, since we are
working instead to integrate websteps in miniooni.

Issue ooni/probe#1790 tracks the work
required to re-enabled the tests I'm skipping with this diff.

This work is part of ooni/probe#1733.
@bassosimone bassosimone added this to the Sprint 50 - Amphipoda milestone Oct 11, 2021
@bassosimone bassosimone removed this from the Sprint 50 - Amphipoda milestone Oct 22, 2021
@bassosimone bassosimone added the wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case) label Feb 9, 2022
@bassosimone
Copy link
Contributor Author

We're not doing that until we start using this code.

ainghazal pushed a commit to ainghazal/probe-cli that referenced this issue Mar 8, 2022
@bassosimone
fix(ooapi): disable tests we're not using (ooni#525)
14c46ce 
At the moment ooapi is not used. It will eventually be used since
it's a better way of accessing the OONI backend API.

To fix these tests, we need to fix the swagger emitted by the
backend API, which is not a priority at the moment, since we are
working instead to integrate websteps in miniooni.

Issue ooni/probe#1790 tracks the work
required to re-enabled the tests I'm skipping with this diff.

This work is part of ooni/probe#1733.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
ooni/probe-engine priority/low wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone