Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobile: add dnscheck to experimental #1973

Closed
bassosimone opened this issue Jan 14, 2022 · 2 comments · Fixed by ooni/probe-android#477
Closed

mobile: add dnscheck to experimental #1973

bassosimone opened this issue Jan 14, 2022 · 2 comments · Fixed by ooni/probe-android#477
Assignees
@aanorbel
Labels
ooni/probe-mobile issues related to OONI Probe mobile priority/medium Normal priority issue

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Jan 14, 2022 •
edited
Loading

This issue is about modifying the experimental suite for probe-android and probe-ios to include DNSCheck. We have already done this work in ooni/probe-android#477 and ooni/probe-ios#462, but these PRs has stalled due to the uncertainty around torsf. We want to start having DNSCheck in master. We'll consider this issue closed when we'll have DNSCheck inside master.
@bassosimone bassosimone added ooni/probe-mobile issues related to OONI Probe mobile priority/medium Normal priority issue and removed triage labels Jan 27, 2022
@aanorbel aanorbel mentioned this issue Feb 7, 2022
Merged
bassosimone added a commit to ooni/probe-android that referenced this issue Feb 7, 2022
@bassosimone @aanorbel
feat: add dnscheck to experimental (#477)
4b634b1 
This diff adds dnscheck to experimental. Originally, in the related PR
(#477) we also added support
for torsf. But that has been backed out until we figure out exactly the
correct configuration (ooni/probe#2004).

Reference issue: ooni/probe#1973).

Co-authored-by: Norbel Ambanumben <aanorbel@gmail.com>
@bassosimone
Copy link
Contributor Author

Reopening until we have dnscheck also on iOS.

@bassosimone bassosimone reopened this Feb 7, 2022
@bassosimone
Copy link
Contributor Author

We now have DNSCheck on both iOS and Android! 🥳

Thanks @aanorbel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aanorbel aanorbel

Labels
ooni/probe-mobile issues related to OONI Probe mobile priority/medium Normal priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add dnscheck to experimental ooni/probe-android
2 participants
@bassosimone @aanorbel