Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probeservices: replace psX.ooni.io with api.ooni.io #2147

Closed
bassosimone opened this issue Jun 14, 2022 · 1 comment
Closed

probeservices: replace psX.ooni.io with api.ooni.io #2147

bassosimone opened this issue Jun 14, 2022 · 1 comment
Assignees
@bassosimone
Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/medium refactoring techdebt This issue describes technical debt

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Jun 14, 2022 •
edited
Loading

This issue is about refactoring probeservices to use a single entry point for the backend: api.ooni.io. This is what the backend expects us to do and the psX.ooni.io names should be considered legacy now.

While there, I'll try to avoid deprecated names not just in code but also in testing code <insert here meme>.
@bassosimone bassosimone added priority/medium refactoring ooni/probe-engine techdebt This issue describes technical debt cleanup There's need to cleanup stuff a bit labels Jun 14, 2022
@bassosimone bassosimone self-assigned this Jun 14, 2022
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 2, 2022
@bassosimone
fix(probeservices): use api.ooni.io
3505e90 
See ooni/probe#2147
@bassosimone bassosimone mentioned this issue Sep 2, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 2, 2022
@bassosimone
fix(probeservices): use api.ooni.io (#926)
7df2579 
See ooni/probe#2147.

Note that this PR also tries to reduce usage of legacy names inside unit/integration tests.
@bassosimone
Copy link
Contributor Author

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/medium refactoring techdebt This issue describes technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone