You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Around one year ago we experimented using the TProxy abstraction for implementing integration testing. Where this experiment had been partially successful in allowing us to write integration testing, we eventually stopped it midway when we removed the Fall 2021 prototype of the websteps experiment. Since then, this code is basically unused. What's more, it is also becoming partially annoying because it introduces an interface between the high-level part of netxlite and the getaddrinfo engine (which I noticed while working on #1516). So, my argument here is that the code that survived from the removal of websteps Fall 2021 is ~50 LoC of unused abstractions and we probably want to remove this unused abstraction. Shall we need something similar in the future, we could introduce it again. Recently, @fortuna mentioned to me that probably shadowsocks is a good way to have a VPN on a probe (e.g., a mobile probe) that moves the data outside the device into a network in which we implement censorship for testing. If we implement such a plan, probably we need something slightly different from what we used to do with TProxy. Hence, I am going to remove TProxy.
The text was updated successfully, but these errors were encountered:
* cleanup: remove UnderlyingNetworkLibrary and TProxy
While there, replace mixture of mocking and real connections inside
quicping with pure mocking of network connections.
Closesooni/probe#2224
* cleanup: we don't need a SimpleResolver now
This type was only used by UnderlyingNetworkLibrary and all the
rest of the code uses Resolver. So, let's avoid complexity by zapping
the SimpleResolver type and merging it inside Resolver.
This functionality has slightly changed since when we removed it
in ooni/probe#2224.
Nevertheless, in #969, we
determined that something like the previous TProxy, with small
changes, was required to support ooni/probe#2340.
We originally removed the TProxy in ooni/probe#2224. Nevertheless, in #969, we determined that something like the previous TProxy, with small changes, was required to support ooni/probe#2340. So, this pull request reintroduces a slightly-modified TProxy functionality that better adapts to the `--remote=REMOTE` use case.
Around one year ago we experimented using the
TProxy
abstraction for implementing integration testing. Where this experiment had been partially successful in allowing us to write integration testing, we eventually stopped it midway when we removed the Fall 2021 prototype of thewebsteps
experiment. Since then, this code is basically unused. What's more, it is also becoming partially annoying because it introduces an interface between the high-level part of netxlite and the getaddrinfo engine (which I noticed while working on #1516). So, my argument here is that the code that survived from the removal of websteps Fall 2021 is ~50 LoC of unused abstractions and we probably want to remove this unused abstraction. Shall we need something similar in the future, we could introduce it again. Recently, @fortuna mentioned to me that probably shadowsocks is a good way to have a VPN on a probe (e.g., a mobile probe) that moves the data outside the device into a network in which we implement censorship for testing. If we implement such a plan, probably we need something slightly different from what we used to do with TProxy. Hence, I am going to remove TProxy.The text was updated successfully, but these errors were encountered: