Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netxlite: add support for extracting CNAME #2225

Closed
bassosimone opened this issue Aug 23, 2022 · 0 comments · Fixed by ooni/probe-cli#875
Closed

netxlite: add support for extracting CNAME #2225

bassosimone opened this issue Aug 23, 2022 · 0 comments · Fixed by ooni/probe-cli#875
Assignees
@bassosimone
Labels
data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@bassosimone
Copy link
Contributor

This issue is about adding to netxlite support for extracting the CNAME from DNS replies. This work is a stepping stone to move towards #1516. It's also part of #2096, because we implemented CNAME in the websteps winter 2022 edition.
@bassosimone bassosimone added enhancement improving existing code or new feature priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing methodology issues related to the testing methodology data quality ooni/probe-engine labels Aug 23, 2022
@bassosimone bassosimone self-assigned this Aug 23, 2022
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 23, 2022
@bassosimone
feat(netxlite): support extracting the CNAME
1828b40 
Closes ooni/probe#2225
@bassosimone bassosimone mentioned this issue Aug 23, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 23, 2022
@bassosimone
feat(netxlite): support extracting the CNAME (#875)
cc24f28 
* feat(netxlite): support extracting the CNAME

Closes ooni/probe#2225

* fix(netxlite): attempt to increase coverage and improve tests

1. dnsovergetaddrinfo: specify the behavior of a DNSResponse returned
by this file to make it line with normal responses and write unit tests
to make sure we adhere to expectations;

2. dnsoverudp: make sure we wait to deferred responses also w/o a
custom context and post on a private channel and test that;

3. utls: recognize that we can actually write a test for NetConn and
what needs to change when we'll use go1.19 by default will just be
a cast that at that point can be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(netxlite): support extracting the CNAME ooni/probe-cli
1 participant
@bassosimone