Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

measurexlite: include CNAME in DNS answers #2227

Closed
bassosimone opened this issue Aug 23, 2022 · 0 comments · Fixed by ooni/probe-cli#877
Closed

measurexlite: include CNAME in DNS answers #2227

bassosimone opened this issue Aug 23, 2022 · 0 comments · Fixed by ooni/probe-cli#877
Assignees
@bassosimone
Labels
data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Aug 23, 2022 •
edited
Loading

This issue is about extracting the CNAME from the DNSResponse and include it into the archival data format answers.

This is part of #1516.
@bassosimone bassosimone self-assigned this Aug 23, 2022
@bassosimone bassosimone added enhancement improving existing code or new feature priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing methodology issues related to the testing methodology data quality ooni/probe-engine labels Aug 23, 2022
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 23, 2022
@bassosimone
feat: save CNAME into archival data format
1471161 
When a DNSResponse contains a non-empty CNAME, we include it
into the related list of answers.

Closes ooni/probe#2227
@bassosimone bassosimone mentioned this issue Aug 23, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 23, 2022
@bassosimone
feat: save CNAME into archival data format (#877)
60b7d1f 
* feat: save CNAME into archival data format

When a DNSResponse contains a non-empty CNAME, we include it
into the related list of answers.

Closes ooni/probe#2227

* doc: add design note

While there, make code more compact and robust to a case where
we're going to extract additional answers.

* doc: document the expected growth of extraction function

Based on feedback by @DecFox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: save CNAME into archival data format ooni/probe-cli
1 participant
@bassosimone