Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: Missing experiment name #2248

Closed
arky opened this issue Aug 30, 2022 · 0 comments · Fixed by ooni/probe-cli#913
Closed

panic: Missing experiment name #2248

arky opened this issue Aug 30, 2022 · 0 comments · Fixed by ooni/probe-cli#913
Assignees
@bassosimone
Labels
bug Something isn't working ooni/probe-engine priority/high techdebt This issue describes technical debt user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@arky
Copy link

arky commented Aug 30, 2022

Describe the bug
If no options are given, the program emits an panic error.

Using 3.16.0-alpha.1 release AMD64 gnu/Linux build
To Reproduce
Run the program without any arguments.

$ ./miniooni-linux-amd64 --version
3.16.0-alpha.1

$ ./miniooni-linux-amd64
panic: Missing experiment name
goroutine 1 [running]:
github.com/ooni/probe-cli/v3/internal/runtimex.PanicIfFalse(...)
/home/runner/work/probe-cli/probe-cli/internal/runtimex/runtimex.go:17
main.Main()
/home/runner/work/probe-cli/probe-cli/internal/cmd/miniooni/libminiooni.go:152 +0x219
main.main()
/home/runner/work/probe-cli/probe-cli/internal/cmd/miniooni/main.go:10 +0x17
Steps to reproduce the behavior.

Expected behavior

The expected behavior is output the help screen '--help' output.

System information (please complete the following information):

  • Device: Ubuntu
  • OS: Ubuntu 22.04.1 LTS
  • OONI Probe version: 3.16.0-alpha.1
@arky arky added bug Something isn't working triage labels Aug 30, 2022
@bassosimone bassosimone added priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing ooni/probe-engine techdebt This issue describes technical debt and removed triage labels Aug 31, 2022
@bassosimone bassosimone mentioned this issue Aug 31, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 31, 2022
@bassosimone
feat(miniooni): make CLI much more user friendly (#913)
0bc6aae 
Part of ooni/probe#2184, because I wanted
to allow swapping commands and options more freely.

As a side effect, this PR closes ooni/probe#2248.

AFAICT, every usage that was legal before is still legal. What has
changed seems the freedom to swap commands and options and a much
better help that lists the available options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working ooni/probe-engine priority/high techdebt This issue describes technical debt user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(miniooni): make CLI much more user friendly ooni/probe-cli
2 participants
@bassosimone @arky