iOS: QA for release 3.8.3

[bassosimone]

Preparing the master branch for release

• merge any other feature PR we may need:
  • chore: prepare for release 3.8.3 probe-ios#525

Tests and results

• while a nettest is running
  • put the app in the background and ensure you can come back with an decreased ETA
    • ❌ the progress bar is still misbehaving for iOS all: incorrect progress estimates in percents in log #2058
  • check that the title changes as we change the nettests we're running
• after the test has run
  • ensure the number of run tests has been updated
  • check that the data usage numbers have increased
  • try to adjust the filter and validate that only the filtered results appear
    • ❌ issue with filtering ios: blank suite names in results filtering #2510
  • tap the result row
    • check that the last run test is highlighted
    • check that the date & time of the test are correct and displayed in the timezone of the phone
    • check that the country & network are resolved properly
  • tap the measurement row
    • check that the country & network are resolved properly
    • check that it’s possible to view the log
    • check that it’s possible to view data
      • check that the report_id is not "", unless publish result is disabled (see settings test section)
      • check that the test_start_time in the measurement is using GMT
  • disable automatic measurement upload
    • check that the upload all (or individual upload) toast is shown
      • ❌ ios: hidden individual upload-measurement toast #2511 & Individual upload buttons don't work on iOS  #2487
    • tap on upload on an individual test and check it works
      • ❌ not possible to tap because the button is actually hidden
    • tap on upload all and check it works
      • ❌ ios: upload all button does not seem to work #2512 & Individual upload buttons don't work on iOS  #2487
• run the websites tests
  • tap on Choose Websites
    • run the test with a specified set of 2 websites: https://ooni.torproject.org/, https://expired.badssl.com/
  • tap on settings and re-run the test changing
    • the test duration to a very short runtime
    • enabling only one category to test and checking on that is tested
      • ❌ ios: app crashes when disabling all categories #2513
  • tap the result row
    • check that the summary shows some number blocked some accessible
    • check that the blocked sites are displayed first
    • check that the icons are displayed next to each test
    • check that the data usage shows a sane number, ex 6.3MB up, 5.8MB down
    • check that the total runtime shows a sane number, ex. 257s
  • tap the measurement row
    • check that everything is displayed properly in this screen
    • check that the runtime is sane ex 2.71s
    • repeat this for on measurement which is OK and one which is blocked (if present)
• run the IM tests
  • tap on settings and re-run the test changing
    • disable telegram, signal and facebook messenger; check that only whatsapp is run
  • tap on the result row
    • check that the total counts on top match
    • check that the data usage shows a sane number, ex 36KB up, 18KB down
    • check that the total runtime shows a sane number, ex. 2.16s
• run the performance test
  • tap on settings and re-run the test changing
    • disable all tests but dash; check that only dash is run
  • check that you see upload, download and video speed in the summary
  • tap the result row
    • check that the summary view has video, upload, download and ping
    • check that the data usage shows a sane number, ex 22MB up, 104MB down
    • check that the total runtime shows a sane number, ex. 54s
  • tap the measurement row
    • check that everything is OK

Settings

• notifications
  • disable notifications in the system settings and then tab to re-enable them and make sure it asks you to enable notifications from the system settings
• advanced
  • enable debug logs and run a test; check that the logs are at debug level verbosity

About

• make sure all links are working as intended

OONI Run v1

We should also test the following links using OONI Run v1. The original document did not spell out which was the source from which we should be trying to load the links, so for now I'd say it's fine to try and use GitHub.

• Web Connectivity
  • no inputs: https://run.ooni.io/nettest?tn=web_connectivity&mv=2.0.0
    • ❌ mobile: inconsistent handling of web_connectivity OONI-Run-v1 link without URLs #2514
  • empty inputs: https://run.ooni.io/nettest?tn=web_connectivity&ta=%7B%22urls%22%3A%5B%5D%7D&mv=2.0.0
    • ❌ mobile: inconsistent handling of web_connectivity OONI-Run-v1 link without URLs #2514
  • partial input: https://run.ooni.io/nettest?tn=web_connectivity&ta=%7B%22urls%22%3A%5B%22http%3A%2F%2F%22%5D%7D&mv=2.0.0
    • ❌ ios: invalid handling of OONI Run v1 link with partial URL #2515
  • valid URLs: https://run.ooni.io/nettest?tn=web_connectivity&ta=%7B%22urls%22%3A%5B%22http%3A%2F%2Fwww.google.it%22%2C%22https%3A%2F%2Frun.ooni.io%2F%22%5D%7D&mv=2.0.0
  • crash: https://run.ooni.io/nettest?tn=web_connectivity&ta=%7B%22urls%22%3A%5B%22http%3A%2F%2Fwww.google.it%22%2C%22https%3A%2F%2Frun.ooni.io&mv=2.0.0
• NDT: https://run.ooni.io/nettest?tn=ndt&mv=2.0.0
• DASH: https://run.ooni.io/nettest?tn=dash&mv=2.0.0
• HIRL: https://run.ooni.io/nettest?tn=http_invalid_request_line&mv=2.0.0
• HHFM https://run.ooni.io/nettest?tn=http_header_field_manipulation&mv=2.0.0
• with invalid minimum version: https://run.ooni.io/nettest?tn=ndt&mv=15.0.0
• with invalid nettest name: https://run.ooni.io/nettest?tn=antani&mv=2.0.0

[bassosimone]

We did all the QA we needed.