torsf: TestRunWithExistingTor hangs forever #2540
Assignees
Labels
bug
Something isn't working
needs investigation
This issue needs extra data and investigation
ooni/probe-engine
priority/high
releaseBlocker
This issue blocks releasing
Comments
bassosimone
added
bug
bassosimone
added a commit
to ooni/probe-cli
that referenced
this issue
Sep 22, 2023
This diff makes the policy previously known as loadable and now know as the static policy easier to use, by having a constructor that reads from a key-value store and by passing it a fallback policy to use. With this design, it should be possible to have code that uses the static policy if applied, falling back to whatever policy we are otherwise constructing into the NewNetwork constructor. In a subsequent commit, I will hook this code into NewNetwork, so that we can override the policy by changing the filesystem. While there, notice several failures in the test suite and apply workarounds (see ooni/probe#2539, ooni/probe#2540, ooni/probe#2541). Part of ooni/probe#2531.
|
Probably, this is the same issue as: https://forum.torproject.org/t/problems-with-snowflake-since-2023-09-20-broker-failure-unexpected-error-no-answer/9346 |
4 tasks
bassosimone
added a commit
to ooni/probe-cli
that referenced
this issue
Oct 6, 2023
We're doing this due to problems with `cdn.sstatic.net`: - https://lists.torproject.org/pipermail/anti-censorship-team/2023-September/000315.html - https://forum.torproject.org/t/problems-with-snowflake-since-2023-09-20-broker-failure-unexpected-error-no-answer/9346 The reference issue is ooni/probe#2540. While there, fix a typo in a test name. --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
|
We have fixed the underlying issue (thanks @cohosh!). And I am going to close this PR. However, I am not very fond of how much static configuration is embedded into the probe source code. I'm wondering of whether there is a way for us to have the check-in API tell us which is the proper SNI for Snowflake. This would reduce the need to release frequently. In any case, this topic is probably best being addressed as a new, separate issue. |
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this issue
Feb 13, 2024
…#1297) This diff makes the policy previously known as loadable and now know as the static policy easier to use, by having a constructor that reads from a key-value store and by passing it a fallback policy to use. With this design, it should be possible to have code that uses the static policy if applied, falling back to whatever policy we are otherwise constructing into the NewNetwork constructor. In a subsequent commit, I will hook this code into NewNetwork, so that we can override the policy by changing the filesystem. While there, notice several failures in the test suite and apply workarounds (see ooni/probe#2539, ooni/probe#2540, ooni/probe#2541). Part of ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this issue
Feb 13, 2024
We're doing this due to problems with `cdn.sstatic.net`: - https://lists.torproject.org/pipermail/anti-censorship-team/2023-September/000315.html - https://forum.torproject.org/t/problems-with-snowflake-since-2023-09-20-broker-failure-unexpected-error-no-answer/9346 The reference issue is ooni/probe#2540. While there, fix a typo in a test name. --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
TestRunWithExistingTortest runs for a long time (probably ~forever) and logs these messages:I am going to disable this integration test, but we must fix this issue before releasing 😅 .
To reproduce:
go test -run TestRunWithExistingTor -v -count 1 ./internal/experiment/torsfThe text was updated successfully, but these errors were encountered: