QA: throttlingWithHTTP is flaky #2668
Assignees
Labels
Comments
bassosimone
added a commit
to ooni/probe-cli
that referenced
this issue
Feb 7, 2024
While approaching ooni/probe#2667, I recognized that the approach we're using to generate `SummaryKeys` is redundant, verbose, and fragile. This diff attempts to improve our implementation. We define new types for generating summary keys and `engine.MeasurementSummaryKeys` to either return the proper summary keys, if the experiment `TestKeys` support that or return a default value. While there, disable the flaky `throttlingWithHTTP` QA check (see ooni/probe#2668).
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this issue
Feb 13, 2024
While approaching ooni/probe#2667, I recognized that the approach we're using to generate `SummaryKeys` is redundant, verbose, and fragile. This diff attempts to improve our implementation. We define new types for generating summary keys and `engine.MeasurementSummaryKeys` to either return the proper summary keys, if the experiment `TestKeys` support that or return a default value. While there, disable the flaky `throttlingWithHTTP` QA check (see ooni/probe#2668).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This test is flaky because we start dropping packets right off the bat. We should instead write a test that starts dropping packets after we have seen the Host header, such that we can get more consistent failures.
The text was updated successfully, but these errors were encountered: