Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webconnectivitylte: expire DNS whoami results #2671

Closed
bassosimone opened this issue Feb 8, 2024 · 0 comments · Fixed by ooni/probe-cli#1499
Closed

webconnectivitylte: expire DNS whoami results #2671

bassosimone opened this issue Feb 8, 2024 · 0 comments · Fixed by ooni/probe-cli#1499
Assignees
@bassosimone
Labels
bug Something isn't working data quality funder/otffoss2023-2024 ooni/probe-engine priority/high

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Feb 8, 2024 •
edited
Loading

We use a singleton and never expire the cache. Which means potentially we miss cases where the network changes. To avoid this issue, we need to implement expiring such that we issue whoami queries periodically.
@bassosimone bassosimone self-assigned this Feb 8, 2024
@bassosimone bassosimone mentioned this issue Feb 8, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 8, 2024
@bassosimone
fix(DNSWhoamiService): implement cache expiration (#1499)
576aa23 
Because the singleton is always active, we need to expire the cache
otherwise we don't catch changes in the client network.

Part of ooni/probe#2669

Closes ooni/probe#2671
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(DNSWhoamiService): implement cache expiration (ooni#1499)
ab5a1cb 
Because the singleton is always active, we need to expire the cache
otherwise we don't catch changes in the client network.

Part of ooni/probe#2669

Closes ooni/probe#2671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working data quality funder/otffoss2023-2024 ooni/probe-engine priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(DNSWhoamiService): implement cache expiration ooni/probe-cli
1 participant
@bassosimone