Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpclientx: fast recovery on error and endpoint index #2728

Closed
bassosimone opened this issue May 3, 2024 · 0 comments · Fixed by ooni/probe-cli#1586
Closed

httpclientx: fast recovery on error and endpoint index #2728

bassosimone opened this issue May 3, 2024 · 0 comments · Fixed by ooni/probe-cli#1586
Assignees

Comments

@bassosimone
Copy link
Contributor

To replace httpapi for test helpers, httpclientx needs two extra functionality:

  1. fast recovery in case a previous attempt failed (e.g., we immediately get connection reset by peer and, in such a case, it does not make sense to wait for a schedule interval before starting the next attempt);
  2. returning the index of the endpoint that succeeded, which is required to know which test helper we used.

Once we have implemented both, it is safe to move forward and use httpclientx for the test helpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant