Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check raw socket #41

Merged
merged 3 commits into from
Mar 12, 2013
Merged

Check raw socket #41

merged 3 commits into from
Mar 12, 2013

Conversation

aagbsn
Copy link
Contributor

@aagbsn aagbsn commented Feb 18, 2013

If you'd rather not use OONI as root, you can setcap python. This set of commits tests experimentally for raw socket support first before asking for root.

@ioerror
Copy link
Contributor

ioerror commented Feb 25, 2013

I think an ideal way to do this would be to write a small C program to handle this specific thing, I did such a thing for arm at toorcamp - that allows for that small program to have a setuid/setcap difference.

Thoughts?

@aagbsn
Copy link
Contributor Author

aagbsn commented Feb 26, 2013

Could you elaborate a bit on how this might work or reference the code for arm?

@ioerror
Copy link
Contributor

ioerror commented Feb 26, 2013

arm is the anonymizing relay monitor - just to be clear - i just wrote a small C program that ran an absolute path with elevated privs - I didn't want all of python and all code under a given python to have elevated ability.

@aagbsn
Copy link
Contributor Author

aagbsn commented Feb 26, 2013

ah, so we would add something like bin/ooniprobe-privileged ? And we would need a mechanism to determine what privileges are required by a test and whether or not it is running with those privileges? The latter is what this pull request is addressing - which is a separate task from isolating which commands may be run with elevated privileges.

@hellais
Copy link
Member

hellais commented Mar 1, 2013

@ioerror are you going to review this?

@isislovecruft
Copy link
Contributor

@ioerror, if you would like to add a feature branch for that C setuid/setcap program, that would be awesome.

For now, I am going to consider this a separate issue because these patches determine if the program has/wants the ability to create raw sockets, which is want ooni-probe wants (we don't actually want all of root's privileges).

@isislovecruft
Copy link
Contributor

I'm approving and merging. I think that having an entirely separate program, while really cool and a great idea, is a separate issue from tests being able to determine if they need raw sockets.

isislovecruft added a commit that referenced this pull request Mar 12, 2013
@isislovecruft isislovecruft merged commit 325e0f2 into ooni:master Mar 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants