Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run v2 - NMS: Updates to copy and URLs not appearing as expected in app #167

Closed
jbonisteel opened this issue May 21, 2024 · 1 comment
Closed

Comments

@jbonisteel
Copy link

jbonisteel commented May 21, 2024

Here are the detailed steps that I took to reproduce this issue:

In the app on my device:

  • Ensure install updates automatically is off for the 'Trusted International Media Card'

In dashboard:

  • Edit the ‘Trusted International Media card’
  • I added this copy to the long description “this is a piece of updated text”
  • I added the URL cbc.ca/news to the inputs

Go back to app on my device:

  • Navigate to the ‘trusted international media’ test overview screen
  • Pull down to refresh
  • I see the ‘review update’ tag, go through the review update flow (screen recording starts at this point)
  • Return to test overview screen
  • The revised copy and the new url are NOT apparent on this screen. I would have expected to see them
  • I then navigated back to the dashboard, hit Run button
  • the new added URL (cbc.ca/news) does NOT appear on the run tests view
  • When I run the test, the new URL does NOT appear in the results (it doesnt seem like it was tested)

As you'll notice in the screenrecording, at this point, I navigate back to the overview to the trusted international media overview screen and only then do I see the added copy + URL. However, if I go back again to the run tests view, the new URL is still not listed there.

Here is a link to the screen recording: https://photos.app.goo.gl/PzRnV4bBB81jEx7h9

@jbonisteel jbonisteel changed the title Run v2 NMS: Updates to copy and URLs not appearing as expected in app Run v2 - NMS: Updates to copy and URLs not appearing as expected in app May 21, 2024
aanorbel added a commit to ooni/probe-android that referenced this issue May 22, 2024
Fixes ooni/run#167 ,
ooni/run#168

## Proposed Changes

- Call `Url.checkExistingUrl` when updating descriptor, fixes
ooni/run#168
- Restructure `OverviewActivity` to ensure UI is updated when updates
are accepted.
  -
@jbonisteel
Copy link
Author

This is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants