Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torsf: document persistent datadir and rendezvous method #231

Merged
merged 5 commits into from
Feb 7, 2022
Merged

torsf: document persistent datadir and rendezvous method #231

merged 5 commits into from
Feb 7, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Feb 7, 2022 •
edited
Loading

Checklist

Description

This diff documents new options we have added to the torsf experiment
after the ooni/probe#2004 discussion.

The related probe-cli PR is: ooni/probe-cli#683

@bassosimone
torsf: document persistent datadir and rendezvous method
38c97f2 
This diff documents new options we have added to the torsf experiment
after the ooni/probe#2004 discussion.

The related probe-cli PR is: ooni/probe-cli#683
@bassosimone bassosimone requested a review from hellais as a code owner February 7, 2022 12:06
bassosimone
bassosimone commented Feb 7, 2022
View reviewed changes
nettests/ts-030-torsf.md Outdated Show resolved Hide resolved
bassosimone
bassosimone commented Feb 7, 2022
View reviewed changes
nettests/ts-030-torsf.md Outdated Show resolved Hide resolved
bassosimone
bassosimone commented Feb 7, 2022
View reviewed changes
nettests/ts-030-torsf.md Outdated Show resolved Hide resolved
@bassosimone bassosimone mentioned this pull request Feb 7, 2022
Merged
3 tasks
hellais
hellais reviewed Feb 7, 2022
View reviewed changes
nettests/ts-030-torsf.md Outdated Show resolved Hide resolved
hellais
hellais reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment on how to improve the docs, but otherwise looks good to merge.

@bassosimone bassosimone merged commit edd0550 into master Feb 7, 2022
@bassosimone bassosimone deleted the issue/2004 branch February 7, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais hellais left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassosimone @hellais