Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support different email for signin #447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kumm
Copy link

@kumm kumm commented May 28, 2013

Now barkeep thinks my gmail address for signin is the same to the email address in my commits. This is not the case.

I've introduced a new login field for signin, and made current email address editable.
Just the signin process changed slightly, everything works as before. Except you can configure your email address.
As before, all outgoing mail sent to this address, and the commits have to contain this address too.
A migration also included to fill the new login field to the current email, so existing users works after this change.

In general, this is another apporach to issue #426

@netwjx
Copy link

netwjx commented Jul 5, 2013

+1

@Danesz
Copy link

Danesz commented Aug 24, 2013

Hi kumm,

how can I use your modifications in barkeep?
I cloned your master barkeeper repo and installed it, but the login page is always the google's page.

Thanks!

@kumm
Copy link
Author

kumm commented Aug 24, 2013

I have not changed the authentication method. It's oauth with google. So the login page is always the google's page.
You have to login by google. The only thing changed, is you don't have to use the same email address for login, and for the git commits.

@Danesz
Copy link

Danesz commented Aug 26, 2013

ok, thank you!

@esamattis
Copy link

I tried merging this on top of bb24f22 but I got NoMethodError - undefined method login for #<User:0x0000000347eb88> error on /settings.

Full stack trace https://gist.github.com/epeli/10867578

@esamattis
Copy link

Update: It seems that I just forgot to run the migrations. Ok to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants