Lookup namespace from original element. Fixes #51

oozcitak · Aug 31, 2020 · 21263b3 · 21263b3
1 parent 11da6a8
commit 21263b3
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/src/builder/XMLBuilderImpl.ts b/src/builder/XMLBuilderImpl.ts
@@ -702,10 +702,14 @@ export class XMLBuilderImpl implements XMLBuilder {
       for (const attr of ele.attributes) {
         const attrQName = attr.prefix ? attr.prefix + ':' + attr.localName : attr.localName
         const [attrPrefix] = namespace_extractQName(attrQName)
-        if (attrPrefix === null) {
+        let newAttrNS = attr.namespaceURI
+        if (newAttrNS === null && attrPrefix !== null) {
+          newAttrNS = ele.lookupNamespaceURI(attrPrefix)
+        }
+
+        if (newAttrNS === null) {
           newEle.setAttribute(attrQName, attr.value)
         } else {
-          const newAttrNS = newEle.lookupNamespaceURI(attrPrefix)
           newEle.setAttributeNS(newAttrNS, attrQName, attr.value)
         }
       }

diff --git a/test/issues/issue-051.test.ts b/test/issues/issue-051.test.ts
@@ -0,0 +1,20 @@
+import $$ from "../TestHelpers";
+
+describe("Replicate issue", () => {
+  // https://github.com/oozcitak/xmlbuilder2/issues/51
+  test("#51 - NamespaceError: The operation is not allowed by Namespaces in XML. [XMLNS] Qualified name includes a prefix but the namespace is null.", () => {
+    const root = $$.create({ version: '1.0', encoding: 'utf-8' })
+      .ele('archive', {
+        version: '4.0',
+        'xmlns:xsi': 'http://www.w3.org/2001/XMLSchema-instance',
+        'xsi:schemaLocation': 'http://xml.datev.de/bedi/tps/document/v04.0 document_v040.xsd',
+        xmlns: 'http://xml.datev.de/bedi/tps/document/v04.0'
+      })
+    const xml = root.end({ headless: true, prettyPrint: true });
+
+    expect(xml).toBe($$.t`
+    <archive version="4.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://xml.datev.de/bedi/tps/document/v04.0 document_v040.xsd" xmlns="http://xml.datev.de/bedi/tps/document/v04.0"/>
+    `)
+  })
+
+})