Skip to content

Commit

Permalink
flush prev
Browse files Browse the repository at this point in the history
  • Loading branch information
clabby committed Sep 30, 2024
1 parent 3ceade2 commit 17b44df
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions crates/derive/src/stages/batch_stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ where
{
fn flush(&mut self) {
if self.is_active().unwrap_or(false) {
self.prev.flush();
self.span = None;

Check warning on line 111 in crates/derive/src/stages/batch_stream.rs

View check run for this annotation

Codecov / codecov/patch

crates/derive/src/stages/batch_stream.rs#L110-L111

Added lines #L110 - L111 were not covered by tests
self.buffer.clear();
}
Expand Down Expand Up @@ -150,9 +151,6 @@ where
// Flush the stage.
self.flush();

// Send a signal to drop the channel that the batch was derived from.
// TODO

return Err(PipelineError::Eof.temp());

Check warning on line 154 in crates/derive/src/stages/batch_stream.rs

View check run for this annotation

Codecov / codecov/patch

crates/derive/src/stages/batch_stream.rs#L152-L154

Added lines #L152 - L154 were not covered by tests
}
BatchValidity::Undecided | BatchValidity::Future => {
Expand Down Expand Up @@ -208,8 +206,7 @@ mod test {
use super::*;
use crate::{
batch::{SingleBatch, SpanBatchElement},
stages::test_utils::{CollectingLayer, MockBatchStreamProvider, TraceStorage},
traits::test_utils::TestL2ChainProvider,
stages::test_utils::{CollectingLayer, MockBatchStreamProvider, TraceStorage}, traits::test_utils::TestL2ChainProvider,
};
use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt};

Expand Down

0 comments on commit 17b44df

Please sign in to comment.