fix(client): Continue derivation on execution failure #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
clabby
force-pushed
the
cl/executor-error-conversion
branch
from
193ca40 to
1ae2bb5
Compare
clabby
force-pushed
the
cl/fix-executor-loop
branch
from
5bcbf9e to
fb81a07
Compare
refcell
approved these changes
Sep 21, 2024
clabby
force-pushed
the
cl/executor-error-conversion
branch
from
1ae2bb5 to
43c896e
Compare
clabby
force-pushed
the
cl/fix-executor-loop
branch
from
fb81a07 to
2bc8b06
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
force-pushed
the
cl/fix-executor-loop
branch
from
2bc8b06 to
0e252a1
Compare
clabby
force-pushed
the
cl/fix-executor-loop
branch
from
0e252a1 to
d95b5ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Applies a fix to the client program's derivation driver, where it threw if a block execution failed. This case can be hit in the event that a malicious batcher posts a bad batch on L1 mainnet.
This change makes us pass the new action tests.