Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): Interop Types #86

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(protocol): Interop Types #86

wants to merge 5 commits into from

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Jan 16, 2025

Description

Adds interop types to the maili-protocol crate ported from kona, and abstracted such that maili uses generic receipt types instead of hardcoded OpReceiptEnvelope types defined in op-alloy.

Closes #27

@refcell
Copy link
Contributor Author

refcell commented Jan 16, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell self-assigned this Jan 16, 2025
@refcell refcell added A-protocol Area: protocol crate C-feat Category: new feature or request labels Jan 16, 2025
@refcell refcell marked this pull request as ready for review January 17, 2025 00:28
receipts: Vec<T>,
}

impl SuperchainBuilder<ReceiptEnvelope> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be hugely important, but notice that here we don't want to create a circular dependency between op-alloy and mailli, so instead of using the OpReceiptEnvelope defined in op-alloy-consensus, we use ReceiptEnvelope from alloy-consensus.

The test utilities themselves however have been made generic over the reveipt type such that kona may define this functionality for the OpReceiptEnevelope type.

@clabby
Copy link
Contributor

clabby commented Jan 17, 2025

I don't think we should add these yet. They'll definitely be changed in the next few weeks as we get the interop proof working.

Definitely glad to port them over once we've solidified them, though, just a bit confusing to have them unfinished and living in two places.

@refcell refcell marked this pull request as draft January 17, 2025 01:49
@emhane emhane added the C-blocked Category: cannot move forward until something else changes label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-protocol Area: protocol crate C-blocked Category: cannot move forward until something else changes C-feat Category: new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Interop - Message Graph
3 participants