-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): Interop Types #86
base: main
Are you sure you want to change the base?
Conversation
📚
|
receipts: Vec<T>, | ||
} | ||
|
||
impl SuperchainBuilder<ReceiptEnvelope> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be hugely important, but notice that here we don't want to create a circular dependency between op-alloy
and mailli
, so instead of using the OpReceiptEnvelope
defined in op-alloy-consensus
, we use ReceiptEnvelope
from alloy-consensus
.
The test utilities themselves however have been made generic over the reveipt type such that kona may define this functionality for the OpReceiptEnevelope
type.
I don't think we should add these yet. They'll definitely be changed in the next few weeks as we get the interop proof working. Definitely glad to port them over once we've solidified them, though, just a bit confusing to have them unfinished and living in two places. |
Description
Adds interop types to the
maili-protocol
crate ported from kona, and abstracted such that maili uses generic receipt types instead of hardcodedOpReceiptEnvelope
types defined inop-alloy
.Closes #27